2021-06-21 18:57 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0005146WHDLoad[All Projects] Generalpublic2021-05-18 12:02
ReporterPaul Head 
Assigned ToWeplProject InfoHD-Installer for OS-Killer
http://whdload.de/
 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version18.6 
Target Version18.7Fixed in Version18.7 
Summary0005146: Down-Arrow key is not working when WHDLoad is loaded from the CLI
DescriptionTyping "WHDLoad" into the Shell gives a summary of options from which the 'Down-Arrow' key or 'Return' key scrolls them down a line at a time. Only 'Return' works now to scroll the line! 18.5 works as expected with the Down-Arrow, but 18.6 doesn't appear to respond to it.
Steps To ReproduceOpen a Shell and type in:

"WHDLoad" and try pressing the Down-Arrow key.

TagsNo tags attached.
MachineUAE
CPU68020
CPUSpeed14
ChipSetAGA
GFXCardNone
ChipMem2 MB
FastMem0 MB
WorkbenchOS 3.0
KickROM39 - Kick 3.0
KickSoftNone
WHDLoad18.6
Attached Files

-Relationships
+Relationships

-Notes

note ~0010095

Wepl (manager)

This is strange. It works fine here.
Does Space for page down work?
Do you have a chance to test it with kickstart 3.1?

note ~0010106

Paul Head (reporter)

Space works and so does Return, but no Down-Arrow. 18.5 works fine!
Tried it with 3.1 and 3.1.4 with same results. This is all under WinUAE though version 4.2.1 (an older version from 2019).

Update: Just tried it on my real 060 Amiga 1200 (a 3.1 system) and it has the exact same issue! Down-Arrow doesn't work! Luckily I had the 18.4 archive still on there and I extracted it and tried the WHDLoad executable from that and the Down-Arrow worked!

note ~0010108

StingRay (developer)

I can confirm the issue, cursor down doesn't work for me either in 18.6. In older versions of WHDLoad it works.

note ~0010115

StingRay (developer)

@Wepl:

Curiosity got the better of me and I checked with WHDLoad 18.4 and 18.6. Main difference is that WHDLoad 18.4 calls _LVOWaitForChar() after cursor down has been pressed, WHDLoad 18.6 omits this call and hence never receives the correct code for cursor down ($9b42, the $42 part is never received).

Should be an easy fix but it makes me wonder that cursor down works on your system, as far as I can see the cursor down handling is broken and doesn't work.

note ~0010118

administrator (administrator)

I had optimized the call to WaitForChar() to be more compatible with VAMOS which does not implement it currently.
It works in KingCon but not in CON.
I think this a bug in CON as a single keypress should also be read by a single Read. However, I will revert and fix it.

note ~0010165

Wepl (manager)

Please check latest beta http://whdload.de/whdload/whd187.lha which should fix the issue.
Thanks for the report :)

note ~0010186

Paul Head (reporter)

That 18.7 beta has fixed the issue so it seems. I've tested on my real 060 3.1 system and my WinUAE 3.0 020 setup. Thanks!

There is another minor issue I noticed (you're thinking WHAT?!)
When WHDLoad is loaded in a small height shell window (like the one from execute command in WB menu) and it gives you those options with Space to show next screen/down arrow or return to scroll single line... well if you instead expand the shell window in height to full screen, then pressing return or down-arrow will 'fill in' the expanded lines of the window per key-press - which is correct of course. Space on the other hand doesn't behave the same and even after expanding the shell window to full it will not 'fill in' the empty screen space and just keeps itself to the initial top few lines (1/3 of the screen).

Lha has a similar setup, but it works as expected and expands and fills all lines (rows) of the window after being expanded and then scrolled.

note ~0010291

Paul Head (reporter)

@Wepl

Are you looking into this? Not sure whether I should reopen it for the above.

note ~0010299

Wepl (manager)

I'm still thinking about if a change for this is worth the effort.
I don't really see the use case to execute whdload via the WB menu.

note ~0010308

Paul Head (reporter)

You're right, it's NOT worth the effort. I just checked out Lha again and even that cocks up when going the other way and even sometimes crashes. I suppose not many people but me prattle about with such things. :-D
+Notes

-Issue History
Date Modified Username Field Change
2021-04-23 00:41 Paul Head New Issue
2021-04-24 23:11 Wepl Assigned To => Wepl
2021-04-24 23:11 Wepl Status new => assigned
2021-04-24 23:43 Wepl Note Added: 0010095
2021-04-26 15:01 Paul Head Note Added: 0010106
2021-04-26 17:51 StingRay Note Added: 0010108
2021-04-27 01:05 StingRay Note Added: 0010115
2021-04-27 11:12 administrator Note Added: 0010118
2021-05-03 01:13 Wepl Status assigned => resolved
2021-05-03 01:13 Wepl Resolution open => fixed
2021-05-03 01:13 Wepl Note Added: 0010165
2021-05-03 01:19 Wepl Fixed in Version => 18.7
2021-05-03 01:19 Wepl Target Version => 18.7
2021-05-04 14:14 Paul Head Note Added: 0010186
2021-05-17 13:06 Paul Head Note Added: 0010291
2021-05-17 21:14 Wepl Note Added: 0010299
2021-05-18 12:02 Paul Head Note Added: 0010308
+Issue History