WHDLoad MantisBT - JamesPond3CD
View Issue Details
0004808JamesPond3CD[WHDLoad Installs Games] CD³²public2020-09-20 14:182020-11-22 18:21
ReporterZoltan Werner 
Assigned ToJOTD 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
MachineCD32
CPU68030
CPUSpeed50
ChipSetAGA
GFXCardNone
ChipMem2 MB
FastMem0 MB
WorkbenchOS 3.1
KickROM40 - Kick 3.1
KickSoftNone
WHDLoad18.5
imported
Summary0004808: Crashes after level 2, save games don't persist
Description- new save trainer comes up after level 1, saves seemingly OK but the save doesn't stay there (not there when you reach saving after level 2)
- after saving on completing level 2 it crashes, see attachment
TagsNo tags attached.
has duplicate 0004807closed JOTD Crashes after level 2, save games don't persist 
Attached Filespng cd32_uae_jp3sav.png (47,417) 2020-10-30 07:23
http://mantis.whdload.de/file_download.php?file_id=1073&type=bug
png

zip JP3_WHDLoad_Logs.ZIP (1,488) 2020-11-16 18:21
http://mantis.whdload.de/file_download.php?file_id=1078&type=bug
zip JamesPond3_v22_beta.zip (2,312) 2020-11-16 22:11
http://mantis.whdload.de/file_download.php?file_id=1079&type=bug
? SAVEGAME (2,815) 2020-11-17 16:36
http://mantis.whdload.de/file_download.php?file_id=1080&type=bug

Notes
(0009211)
JOTD   
2020-10-24 23:46   
I don't have this bug but if the file doesn't exist the slave crashes too...

Can you test this attached slave? and confirm that you're using the CD32 version not the floppy version?
(0009225)
Zoltan Werner   
2020-10-30 07:23   
Checked under WinUAE (no access to real hardware atm).
If jp3.sav doesn't exist it is created after completing the first level, but it's all zeroes - see attachment.
If jp3.sav exists then it crashes when completing first level and trying to save again. It says: DOS-Error #212 (object is not of required type) on writing "".

Just a thought: could saving work by keeping the original CD32 nvram save feature? That way it could be redirected to HD via prefs/env-archive/sys/nv_location or even just save to real nvram on a CD32.
(0009236)
JOTD   
2020-11-10 22:48   
Can't reproduce your issue. Are you using whdload 18? or an older version?

And no, this game isn't using nonvolatile.library but hardware banging saves so it's not possible to save to nv_location.

And if you want to save to real nvram maybe use the real CD32 disc?
(0009238)
Zoltan Werner   
2020-11-11 09:25   
It's WHDLoad 18.5 (it's on one of the attached error screens)

NVRAM: I see, OK. The original disc crashes with fastram expansion, but I'd prefer using HD. Especially with your hack that enables saving after each level.

I'll re-download a JP3 iso and apply your WHDLoad from scratch, perhaps I'll try it with a clean WB instead of my old ClassicWB which has a crapload of stuff installed on it, like MMULib, etc.
(0009241)
JOTD   
2020-11-14 00:16   
Try with FILELOG tooltype, then zip & attach the .whdl_log file that whdload produces on exit. That would help me see what's wrong
(0009246)
Zoltan Werner   
2020-11-15 17:08   
In short: no progress.

Longer: Updated WHDLoad to latest version (18.6xyz). Downloaded "/TOSEC-ISO/CD32/Games/[ISO]/James Pond 3 - Operation Starfi5h (1994)(Kixx)[budget].zip" from the eab file server, applied your latest JP3 whdload installer + the patch attached here.

Tried running it from WB like normal and also with no startup-sequence.

The result is always the same: after level 1 it creates a 232 byte "jp3.sav" which contains 0's only.
After level 2 it crashes when saving, see error on attached screenshot.

I enabled "FileLog" but there's no .whdl_log file in the JP3 directory. I double checked if it were hidden and that's why, but no, it's not there.
(0009247)
Pascal De Maeseneire   
2020-11-15 18:07   
Hi Zoltan Werner,
Please send me an e-mail address to send You my version in zip File.

Best regards,
Pascal
(0009248)
Zoltan Werner   
2020-11-15 18:21   
Hi,

Don't know how to send a priv message here but anyway, it is natloz.renrew at gmail.com.
Thanks for your help!
(0009249)
Pascal De Maeseneire   
2020-11-15 19:08   
Hi Zoltan,
did You received my email,
Does it work on Your system ?
Best regards,
Pascal
(0009250)
Zoltan Werner   
2020-11-15 19:23   
Unfortunately it does the same thing, a little bit differently though.
When saving after 1st level it crashes if JP3.SAV doesn't exist.If it exists (a 0 byte file is ok) it overwrites it to 232 bytes long full of zeroes.At this point I quit by hitting DEL, then reloaded the game.The save was obviously not there (due to all zeroes), but this slave crashes after the 1st level even if it finds the 232byte all-zero sav file.

If you guys can really save after each level then pls attach a proper jp3.sav so I can see if it works with that.
(0009252)
JOTD   
2020-11-15 21:50   
the whdl_log file is in C: by default, my bad.
(0009258)
Zoltan Werner   
2020-11-16 18:21   
Attached are the logs. They were made using above JP3 iso + latest WHDLoad patch + attached slave.
01: deleted JP3.sav, started the game, played through level 1, saved the game. It created the usual 232 byte jp3.sav with all zeroes.
02: played thourgh level 1 again, tried to save but this time it crashed. I have "dump" + memory dump as well if you want. Can't attach here, it's too big.
(0009259)
JOTD   
2020-11-16 22:11   
Ah I think I found the issue. Buffer overflow. Please test attached slave.
(0009260)
Pascal De Maeseneire   
2020-11-17 16:18   
@JOTD

Hi,
I just finished to test Your latest Beta Slave 2.2.

With JP3C32
Save game after Level1 works perfectly now and there isn't any other problems.
I can Quit the game restart and select continue to choose witch save I want to use (WITH NAME JP3) and continue to play it ... many thanks for that.

With JP3AGA
Save game after Level1 works perfectly too.

But If I quit the game and restart it and press continue the position of the save game tell me EMPTY but if a press it... the save position works and I can choose to continue with next level.

My question is, is it normal that the save position (Only Tried Position 0) tell me EMPTY but not empty in reality ?

Many thanks,

Best regards,
Pascal
(0009261)
Pascal De Maeseneire   
2020-11-17 16:37   
JUST ATTACH My SAVEGAME FILE FOR JP3 AGA VERSION
(0009264)
Zoltan Werner   
2020-11-19 20:10   
Latest slave works here too! Could save game after 1st & 2nd levels then load back problem free.

"Play+Forward+Reverse quits to workbench" didn't want to work somehow but it could be due to my xbox 360 controller not playing nice with winuae with this particular combo? Not sure.

@Pascal would be great if you could look.

Thanks for the update!
(0009273)
JOTD   
2020-11-22 18:18   
@Pascal I just saved, changing the name to "SAVED" and it worked. I'm releasing it as is.

@ZoltanWerner BTW The quit combo is Forward+Reverse+Yellow not Forward+Reverse+Play :)

Issue History
2020-09-20 14:18Zoltan WernerNew Issue
2020-09-20 14:18Zoltan WernerFile Added: JP3_quit_after_level2.jpg
2020-09-23 22:29JOTDRelationship addedhas duplicate 0004807
2020-09-26 22:48JOTDAssigned To => JOTD
2020-09-26 22:48JOTDStatusnew => acknowledged
2020-10-24 23:45JOTDFile Added: JamesPond3.zip
2020-10-24 23:46JOTDNote Added: 0009211
2020-10-24 23:47JOTDStatusacknowledged => feedback
2020-10-30 06:23Zoltan WernerStatusfeedback => assigned
2020-10-30 07:23Zoltan WernerFile Added: cd32_uae_jp3sav.png
2020-10-30 07:23Zoltan WernerNote Added: 0009225
2020-11-10 22:48JOTDNote Added: 0009236
2020-11-11 09:25Zoltan WernerNote Added: 0009238
2020-11-14 00:16JOTDNote Added: 0009241
2020-11-15 17:08Zoltan WernerNote Added: 0009246
2020-11-15 18:07Pascal De MaeseneireNote Added: 0009247
2020-11-15 18:21Zoltan WernerNote Added: 0009248
2020-11-15 19:08Pascal De MaeseneireNote Added: 0009249
2020-11-15 19:23Zoltan WernerNote Added: 0009250
2020-11-15 21:50JOTDNote Added: 0009252
2020-11-16 18:21Zoltan WernerFile Added: JP3_WHDLoad_Logs.ZIP
2020-11-16 18:21Zoltan WernerNote Added: 0009258
2020-11-16 22:11JOTDFile Added: JamesPond3_v22_beta.zip
2020-11-16 22:11JOTDNote Added: 0009259
2020-11-16 22:12JOTDStatusassigned => confirmed
2020-11-16 22:12JOTDFile Deleted: JamesPond3.zip
2020-11-17 16:18Pascal De MaeseneireNote Added: 0009260
2020-11-17 16:36Pascal De MaeseneireFile Added: SAVEGAME
2020-11-17 16:37Pascal De MaeseneireNote Added: 0009261
2020-11-19 20:10Zoltan WernerNote Added: 0009264
2020-11-22 18:16JOTDFile Deleted: JP3_quit_after_level2.jpg
2020-11-22 18:18JOTDNote Added: 0009273
2020-11-22 18:21JOTDStatusconfirmed => closed
2020-11-22 18:21JOTDResolutionopen => fixed