WHDLoad MantisBT - BuckRogers
View Issue Details
0003006BuckRogers[All Projects] Generalpublic2014-05-04 09:152014-05-09 14:11
Reportertomse 
Assigned ToJOTD 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
MachineA1200
CPU68030
CPUSpeed50
ChipSetAGA
GFXCardNone
ChipMem2 MB
FastMem0 MB
WorkbenchOS 3.1
KickROM40 - Kick 3.1
KickSoftNone
WHDLoad17.2
imported
Summary0003006: Hanging keys after character creation
DescriptionI made a note of this in 0002829
the text below is a copy paste of this

As an addition, after the creation of a character and you get back to the menu, to create more characters, the cursor/selection (bar) scrolls in an infinite loop, which it does all the way through the creation of the second character. where after finishin, it stops. This happens through all the even number of characters I've created.

happens on A1200 030@50 and A4000 060@50 CSPPC in WB3.1
TagsNo tags attached.
Attached Files? .whdl_register (26,376) 2014-05-06 22:29
http://mantis.whdload.de/file_download.php?file_id=341&type=bug
? BuckRogers.slave (5,156) 2014-05-08 22:37
http://mantis.whdload.de/file_download.php?file_id=343&type=bug

Notes
(0003926)
JOTD   
2014-05-06 12:33   
does it happen with the latest released slave?
(0003928)
tomse   
2014-05-06 12:43   
(Last edited: 2014-05-06 12:44)
yes it does.

the saving of the first character is really slow as well, lots of screen refreshes happens, can't say for other characters as I didn't test saving those.. due to the hanging keys.

I'd be willing to do betatesting before a new release.

(0003929)
JOTD   
2014-05-06 16:05   
Ok, 2 bugs:

- slow/flashing OS swaps: I think that game opens/writes/closes the file a lot of times (I had to patch Anstoss specifically for this very reason)
- hanging keys: can you try the following workaround: use mouse on the "save xxx" question?

When you type keys during OS swaps, some key presses/releases can be lost and the virtual OS running the game is a bit confused.
Another workaround to try would be to type "enter" again.
(0003940)
tomse   
2014-05-06 16:58   
I'll try using mouse to save.
hitting enter on the second character creation doesn't help much..
I think it's the arrow keys that hangs, though the ending result of "YES" to save character is an Enter key.

I'll see what I can do when I get home tonight.
(0003941)
tomse   
2014-05-06 20:16   
Ok, I used the mouse to create the first character, no keys hung.

The second character I created I used they keyboard, there the keyboard hung.

It's the Enter key that hangs, which is also the last key being used before the char is saved.

The save of the char still made a lot of screen refreshes / taking a long time to save.
(0003942)
JOTD   
2014-05-06 20:18   
You can replace enter by click on yes (I tested that it works)

About the save of the char: I'll fix this.
(0003943)
tomse   
2014-05-06 20:35   
(Last edited: 2014-05-06 20:37)
I've done some more testing.

imo, the game is heavily depending on keyboard use, so a hanging enter key is problematic.

I've now tried to save a game using same methods.. and ofc hitting enter for a game makes the key hang.

I've also now noticed that the "slow" saving might be due to allocation of the files, as overwriting a save game is fast.

After a save I made a quit,
new error: it says the game is not saved (this I can live with)

but also WHDLoad gave an exception:


Exception "Access Fault" ($4008)
PC = $FB147CA (ExpMem $377CA)
Long Read From $3ECAB638

(note Running on A4000 060@50 Kick 3.1 OS3.1 w/BetterWB 3.6 if that can help with the error message)

(0003944)
JOTD   
2014-05-06 22:02   
the hanging is only on save (when screen flickers)

I can fix the flicker as I said.

When did the crash occured?
Can you attach the ".whdl_register" file that whdload creates when it crashes and explain exactly when it occurs?
(0003945)
tomse   
2014-05-06 22:29   
The crash occures when you exit to workbench, the regular way by clicking Exit to workbench, you should see it right away on the first menu, you don't even need to create a character or anything.
I don't know if it's "normal" behavior as it is whdload..

I have all the dump files, but attaching only .whdl_register
let me know if you need the rest.
(0003948)
JOTD   
2014-05-06 23:00   
Ok, so no big deal. I can deal with that but that's perfectionnism as you can quit with quitkey.

BTW check the attached .slave in this bugreport and tell me how it goes in the screenflash section.
(0003952)
tomse   
2014-05-06 23:11   
thanks alot for the speedy reply..
unfortunately I'm on my way to bed now..

I'll be checking it when I get back from work tomorrow.
hope thats ok with you.
(0003954)
JOTD   
2014-05-06 23:17   
no problem. I've fixed the "exit" bug too (not in the attached slave).

I'm waiting for your test, and I'll publish the update / close this issue

regards
(0003958)
tomse   
2014-05-07 17:21   
Just tried the new version.
it seems the loading time is a little faster to get to the intro.

but still enter key is hanging, and no change in saving a char
(0003959)
JOTD   
2014-05-07 22:43   
I was wondering about your whdload prefs. Don't you use "writedelay" to some ludicrious value?
(0003961)
tomse   
2014-05-08 11:07   
Im using the default settings. With sysinfo my disk transfers with 23mb/s
(0003962)
JOTD   
2014-05-08 12:37   
I'll try something else and will let you test it.
(0003963)
Psygore   
2014-05-08 14:30   
JOTD, about the enter key hanging: I had the same problem too with some OS games.
I just put a little wait (resload_Delay) before it creates a new file to avoid this problem.
Find the string of characters ";create an empty file" in kickfs.s and add a wait before the 'resload_SaveFile' function.
Hope it helps.
(0003965)
JOTD   
2014-05-08 15:38   
Thanks. I was about to do that in the slave itself (I already intercept dos.Open with MODE_NEWFILE)
(0003966)
tomse   
2014-05-08 21:06   
Thanks JOTD I can't test today, but will be home almost the whole day tomorrow.
(0003968)
JOTD   
2014-05-08 22:38   
I've attached a slave with 1 second wait after RETURN has been pressed.
However, if RETURN is kept pressed, problems could occur.

Please test the "exit to wb" menu too.

BTW I had the problem with winuae. Just pressing another key/RETURN solved it.
(0003977)
tomse   
2014-05-09 11:15   
The problem with the stuck enter key is you can't quit character creation once started, you you'll have to go through all the steps. It'll also fill out a few info for you and you can't go back to correct these.

Thanks, I just tested and things are working great now.
Saving a char still takes some time + there are 2 screen refreshes, but now it seems to work as the diskette version. So unless you're a perfectionist, leave it :-)

The game still tells that the game hasn't been saved when quitting, even though it just was. it's not something that bothers me either.. so I'll leave it to your descision ;-)

Thanks a lot for your patience and the fixes. I'm looking forward to get started playing this game again!
(0003978)
JOTD   
2014-05-09 14:11   
Ok, I think I can release the new version now. The last bug you're reporting will remain unfixed (after all most people quit with quitkey).

thanks for testing.

Issue History
2014-05-04 09:15tomseNew Issue
2014-05-06 12:33JOTDNote Added: 0003926
2014-05-06 12:43tomseNote Added: 0003928
2014-05-06 12:44tomseNote Edited: 0003928bug_revision_view_page.php?bugnote_id=3928#r595
2014-05-06 15:45JOTDAssigned To => JOTD
2014-05-06 15:45JOTDStatusnew => assigned
2014-05-06 16:05JOTDNote Added: 0003929
2014-05-06 16:58tomseNote Added: 0003940
2014-05-06 20:16tomseNote Added: 0003941
2014-05-06 20:18JOTDNote Added: 0003942
2014-05-06 20:35tomseNote Added: 0003943
2014-05-06 20:37tomseNote Edited: 0003943bug_revision_view_page.php?bugnote_id=3943#r597
2014-05-06 22:02JOTDNote Added: 0003944
2014-05-06 22:29tomseNote Added: 0003945
2014-05-06 22:29tomseFile Added: .whdl_register
2014-05-06 22:58JOTDFile Added: BuckRogers.slave
2014-05-06 23:00JOTDNote Added: 0003948
2014-05-06 23:11tomseNote Added: 0003952
2014-05-06 23:17JOTDNote Added: 0003954
2014-05-07 09:16JOTDPrioritynormal => high
2014-05-07 17:21tomseNote Added: 0003958
2014-05-07 22:43JOTDNote Added: 0003959
2014-05-08 11:07tomseNote Added: 0003961
2014-05-08 12:37JOTDNote Added: 0003962
2014-05-08 14:30PsygoreNote Added: 0003963
2014-05-08 15:38JOTDNote Added: 0003965
2014-05-08 21:06tomseNote Added: 0003966
2014-05-08 22:36JOTDFile Deleted: BuckRogers.slave
2014-05-08 22:37JOTDFile Added: BuckRogers.slave
2014-05-08 22:38JOTDNote Added: 0003968
2014-05-09 11:15tomseNote Added: 0003977
2014-05-09 14:11JOTDNote Added: 0003978
2014-05-09 14:11JOTDStatusassigned => closed
2014-05-09 14:11JOTDResolutionopen => fixed